Unset redirect param in MoveLogFormatter::getMessageParameters
authorumherirrender <umherirrender_de.wp@web.de>
Wed, 6 Aug 2014 09:00:47 +0000 (11:00 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Sat, 20 Sep 2014 15:06:02 +0000 (17:06 +0200)
The redirect param is used to get a different message key, so there is
no need to pass it to the message, because the value is stable.
'logentry-move-move' always get a '0' and
'logentry-move-move-noredirect' always a '1'
The value is only visible with uselang=qqx

Change-Id: Ib6a3303e7401e29561165355b3611c3c123bfcd0

includes/logging/MoveLogFormatter.php

index 3913016..35da113 100644 (file)
@@ -37,8 +37,9 @@ class MoveLogFormatter extends LogFormatter {
 
        protected function getMessageKey() {
                $key = parent::getMessageKey();
-               $params = $this->getMessageParameters();
+               $params = $this->extractParameters();
                if ( isset( $params[4] ) && $params[4] === '1' ) {
+                       // Messages: logentry-move-move-noredirect, logentry-move-move_redir-noredirect
                        $key .= '-noredirect';
                }
 
@@ -51,6 +52,7 @@ class MoveLogFormatter extends LogFormatter {
                $newname = $this->makePageLink( Title::newFromText( $params[3] ) );
                $params[2] = Message::rawParam( $oldname );
                $params[3] = Message::rawParam( $newname );
+               unset( $params[4] ); // handled in getMessageKey
 
                return $params;
        }